ibzib commented on a change in pull request #13690:
URL: https://github.com/apache/beam/pull/13690#discussion_r556014838
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -855,9 +855,10 @@ class BeamModulePlugin implements Plugin<Project> {
// configurations because they are never required to be shaded or become
a
// dependency of the output.
def compileOnlyAnnotationDeps = [
- "com.google.auto.value:auto-value-annotations:1.7",
+ "com.google.auto.value:auto-value-annotations:1.7.2",
"com.google.auto.service:auto-service-annotations:1.0-rc6",
"com.google.j2objc:j2objc-annotations:1.3",
+ "com.google.code.findbugs:jsr305:3.0.2",
Review comment:
Can you create a jsr305_version variable to share with the jsr305
library defined in `project.ext.library`?
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -855,9 +855,10 @@ class BeamModulePlugin implements Plugin<Project> {
// configurations because they are never required to be shaded or become
a
// dependency of the output.
def compileOnlyAnnotationDeps = [
- "com.google.auto.value:auto-value-annotations:1.7",
+ "com.google.auto.value:auto-value-annotations:1.7.2",
Review comment:
It looks like there are a couple places that use
`com.google.auto.value:auto-value:1.7`, can you update that to 1.7.2 as well?
And all of these places should probably use an `autovalue_version` variable to
make sure they are using the same version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
