lostluck commented on a change in pull request #13606:
URL: https://github.com/apache/beam/pull/13606#discussion_r556934558
##########
File path: sdks/go/pkg/beam/artifact/materialize.go
##########
@@ -39,27 +42,31 @@ import (
// TODO(lostluck): 2018/05/28 Extract these from their enum descriptors in the
pipeline_v1 proto
const (
+ URNFileArtifact = "beam:artifact:type:file:v1"
+ URNPypiInstallReq = "beam:artifact:role:pypi_install_req:v1"
URNStagingTo = "beam:artifact:role:staging_to:v1"
NoArtifactsStaged = "__no_artifacts_staged__"
)
+var idCounter uint64
Review comment:
Please move this line to just above the generateId function. Go style
doesn't require package variables to be declared at the top of the file.
Please also add a comment why we need a global counter variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
