ajamato commented on a change in pull request #13491:
URL: https://github.com/apache/beam/pull/13491#discussion_r557579670
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
##########
@@ -383,4 +409,70 @@ public boolean equals(@Nullable Object object) {
public int hashCode() {
return Objects.hash(stepName, counters, distributions, gauges);
}
+
+ private boolean equalsMetricName(MetricName metricName, String namespace,
String name) {
+ return (namespace == null || namespace.equals(metricName.getNamespace()))
Review comment:
This equality looks werid, why would it be considered equal if the param
is null?
Can you add a clairifying comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
