ihji commented on a change in pull request #13491:
URL: https://github.com/apache/beam/pull/13491#discussion_r557692931
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
##########
@@ -383,4 +409,70 @@ public boolean equals(@Nullable Object object) {
public int hashCode() {
return Objects.hash(stepName, counters, distributions, gauges);
}
+
+ private boolean equalsMetricName(MetricName metricName, String namespace,
String name) {
+ return (namespace == null || namespace.equals(metricName.getNamespace()))
Review comment:
Yeah, `equals` prefix is misleading. It's more like matching and when
the field will be ignored when the parameter is null. I renamed the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
