ibzib commented on a change in pull request #13658:
URL: https://github.com/apache/beam/pull/13658#discussion_r557783353
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -41,6 +41,7 @@ description = "Apache Beam :: Runners :: Flink $flink_version"
evaluationDependsOn(":sdks:java:core")
evaluationDependsOn(":runners:core-java")
+def checker_qual_version = "2.0.0"
Review comment:
We can remove this now that #13690 is in.
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
+ compile library.java.jackson_databind
+ compile "org.apache.flink:flink-annotations:$flink_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_version"
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_version"
+ compile "org.checkerframework:checker-qual:$checker_qual_version"
Review comment:
We can remove this now that #13690 is in.
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
+ compile library.java.jackson_databind
+ compile "org.apache.flink:flink-annotations:$flink_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_version"
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_version"
Review comment:
I think `org.apache.flink:flink-clients_2.11:$flink_version` should be
changed to a `testCompile` dependency instead.
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
+ compile library.java.jackson_databind
Review comment:
Why do we need to add `jackson_databind`?
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
Why does `jackson_annotations` need to be declared? Can we remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
