iemejia commented on a change in pull request #13715:
URL: https://github.com/apache/beam/pull/13715#discussion_r559575687
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunnerRegistrar.java
##########
@@ -41,8 +39,7 @@ private SparkRunnerRegistrar() {}
public static class Runner implements PipelineRunnerRegistrar {
@Override
public Iterable<Class<? extends PipelineRunner<?>>> getPipelineRunners() {
- return ImmutableList.of(
- SparkRunner.class, TestSparkRunner.class,
SparkStructuredStreamingRunner.class);
+ return ImmutableList.of(SparkRunner.class, TestSparkRunner.class);
Review comment:
No it is not a breaking change because the
SparkStructuredStreamingRunnerProvider takes care of registering the runner
class independently (and this is validated by the tests (Nexmark concretely)
who rely on this shortened translation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
