lostluck commented on a change in pull request #13760:
URL: https://github.com/apache/beam/pull/13760#discussion_r560334776
##########
File path: sdks/go/pkg/beam/core/graph/coder/row.go
##########
@@ -24,13 +24,33 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
+var (
+ defaultEnc RowEncoderBuilder
+ defaultDec RowDecoderBuilder
+
+ // RequireAllFieldsExported when set to true will have the default
coder buildings using
+ // RowEncoderForStruct and RowDecoderForStruct fail if there are any
unexported fields.
+ // When set false, unexported fields in default destination structs
will be silently
+ // ignored when coding.
+ // This has no effect on types with registered coder providers.
+ RequireAllFieldsExported bool
Review comment:
Good call. Or you set it and never register providers, it never gets set
at all. Either way, not ideal.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]