ibzib commented on a change in pull request #13658:
URL: https://github.com/apache/beam/pull/13658#discussion_r560587057
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
I think a better solution is to make `:runners:flink:1.x` a runtimeOnly
instead of dependency instead of a compile dependency in
flink_job_server.gradle, but I will do that in a separate PR since more changes
might be required. BEAM-11664
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
+ compile library.java.jackson_databind
+ compile "org.apache.flink:flink-annotations:$flink_version"
+ compile "org.apache.flink:flink-optimizer_2.11:$flink_version"
+ permitUnusedDeclared "org.apache.flink:flink-clients_2.11:$flink_version"
Review comment:
Same here - since `compile
"org.apache.flink:flink-clients_2.11:$flink_version"` could safely be removed,
we no longer need `permitUnusedDeclared
"org.apache.flink:flink-clients_2.11:$flink_version"`.
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -169,6 +170,17 @@ dependencies {
validatesRunner project(path: ":runners:core-java", configuration:
"testRuntime")
validatesRunner project(project.path)
miniCluster "org.apache.flink:flink-runtime-web_2.11:$flink_version"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(":sdks:java:fn-execution")
+ compile project(path: ":vendor:sdks-java-extensions-protobuf",
configuration: "shadow")
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
I see `compile library.java.jackson_annotations` was removed. So there's
no need to have `permitUnusedDeclared library.java.jackson_annotations` anymore
because we are not declaring it (I don't think the plugin checks for
"transitive declaration," either we explicitly declare a dependency or we don't
declare it at all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
