y1chi commented on a change in pull request #13756: URL: https://github.com/apache/beam/pull/13756#discussion_r561186109
########## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder_test.py ########## @@ -0,0 +1,100 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Unit tests for the sdk container builder module.""" + +# pytype: skip-file + +from __future__ import absolute_import + +import gc +import logging +import unittest +import unittest.mock + +from apache_beam.options import pipeline_options +from apache_beam.runners.portability import sdk_container_builder + + +class SdkContainerBuilderTest(unittest.TestCase): + def tearDown(self): + # Ensures SdkContainerImageBuilder subclasses are cleared + gc.collect() + + def test_can_find_local_builder(self): + local_builder = sdk_container_builder.SdkContainerImageBuilder\ Review comment: it's recommended to use brackets to wrap around multi-line code. ########## File path: sdks/python/apache_beam/options/pipeline_options.py ########## @@ -1036,7 +1036,6 @@ def _add_argparse_args(cls, parser): 'the command line.')) parser.add_argument( '--prebuild_sdk_container_engine', - choices=['local_docker', 'cloud_build'], Review comment: Could you update the document to mention the built-in supported types and the example usage of extension? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
