kamilwu commented on a change in pull request #13355:
URL: https://github.com/apache/beam/pull/13355#discussion_r561773410
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -802,8 +803,8 @@ def add_input(self, accumulator, element, *args, **kwargs):
class ToList(CombinerWithoutDefaults):
"""A global CombineFn that condenses a PCollection into a single list."""
- def __init__(self, label='ToList'): # pylint:
disable=useless-super-delegation
- super(ToList, self).__init__(label)
+ def __init__(self): # pylint: disable=useless-super-delegation
Review comment:
You could remove this constructor completely. The interpreter invokes
`super().__init__()` if there's no constructor anyway. Pylint has also detected
that this is meaningless.
The same applies to `ToList` and `ToDict`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
