TheNeuralBit commented on a change in pull request #13511:
URL: https://github.com/apache/beam/pull/13511#discussion_r562265566
##########
File path: website/www/site/layouts/shortcodes/list_with_icons.html
##########
@@ -0,0 +1,29 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+ */}}
+
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ <div class="icon-list">
+ {{ range $item := $data.community_list }}
Review comment:
Thanks this looks better! `table_with_icons` is still a little bit
hard-coded since it assumes a "purpose", "content" and "action" column. Could
you look at making it accept a list of column names as an argument? If that's
too tricky, please just put a comment in the file to describe the assumption.
##########
File path: website/www/site/layouts/community/baseof.html
##########
@@ -11,30 +11,30 @@
*/}}
<!DOCTYPE html>
- <html lang="{{ .Site.Language.Lang }}" class="no-js">
- <head>
- {{ partial "head.html" . }}
- </head>
- <body class="body" data-spy="scroll" data-target=".page-nav" data-offset="0">
- {{ partial "header.html" . }}
- <div class="clearfix container-main-content">
- <div class="section-nav closed" data-offset-top="90"
data-offset-bottom="500">
- <span class="section-nav-back glyphicon glyphicon-menu-left"></span>
- <nav>
- <ul class="section-nav-list" data-section-nav>
- {{ partial (printf "section-menu/%s/community.html" .Lang) . }}
- </ul>
- </nav>
- </div>
-
- <nav class="page-nav clearfix" data-offset-top="90"
data-offset-bottom="500">
- {{ .TableOfContents }}
- </nav>
-
- <div class="body__contained body__section-nav">
- {{ .Content }}
- </div>
- </div>
- {{ partial "footer.html" . }}
- </body>
- </html>
Review comment:
ping on this
##########
File path: website/www/site/content/en/community/contact-us.md
##########
@@ -20,28 +21,21 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
-# Contact Us
+# Contact us!
There are many ways to reach the Beam user and developer communities - use
whichever one seems best.
-<!-- We use div instead of table shortcode here, because markdownify break
superscripts -->
-<div class="table-wrapper">
+## How to use mailing lists?/What is it?
-| How to contact us | When to use it |
-| ----------------- | ---------------|
-| [user@](https://lists.apache.org/[email protected]) mailing
list | User support and questions
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [dev@](https://lists.apache.org/[email protected]) mailing list
| Development discussions
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [commits@](https://lists.apache.org/[email protected])
mailing list | Firehose of commits, bugs, pull requests, etc.
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [builds@](https://lists.apache.org/[email protected]) mailing
list | Firehose of build notifications from Jenkins
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [JIRA bug tracker](https://issues.apache.org/jira/browse/BEAM) | Report bugs
/ discover known issues |
-| [StackOverflow](https://stackoverflow.com/questions/tagged/apache-beam) |
Ask and answer user support questions |
-| [Slack](https://s.apache.org/beam-slack-channel) | Chat with users and
developers in the ASF Slack. Note: Please [join the #beam
channel](https://s.apache.org/beam-slack-channel) after you [created an
account](https://s.apache.org/slack-invite). Please do not ask Beam questions
in #general. |
+Here should be a short description on what mailing lists are and how to use
them. Also information on how does subscribe, unsubscribe and archives do work
(blank email etc).
Review comment:
Thank you! @griscz could you review the copy changes in this PR to make
sure they match your expectations? The changes should all be in the .md and
.yaml files
##########
File path: website/www/site/content/en/community/contact-us.md
##########
@@ -20,28 +21,28 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
-# Contact Us
+# Contact us!
+
+The Apache Beam community is friendly and welcoming. We are glad to help with
any
+question, suggestion or idea you have. Contact us in the following channels:
+
+### Available contact channels
-There are many ways to reach the Beam user and developer communities - use
-whichever one seems best.
+{{< table_with_icons >}}
-<!-- We use div instead of table shortcode here, because markdownify break
superscripts -->
-<div class="table-wrapper">
+### Mailing list, what are they and how they work
-| How to contact us | When to use it |
-| ----------------- | ---------------|
-| [user@](https://lists.apache.org/[email protected]) mailing
list | User support and questions
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [dev@](https://lists.apache.org/[email protected]) mailing list
| Development discussions
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [commits@](https://lists.apache.org/[email protected])
mailing list | Firehose of commits, bugs, pull requests, etc.
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [builds@](https://lists.apache.org/[email protected]) mailing
list | Firehose of build notifications from Jenkins
([Subscribe](mailto:[email protected])[^1],
[Unsubscribe](mailto:[email protected])[^1],
[Archives](https://lists.apache.org/[email protected])) |
-| [JIRA bug tracker](https://issues.apache.org/jira/browse/BEAM) | Report bugs
/ discover known issues |
-| [StackOverflow](https://stackoverflow.com/questions/tagged/apache-beam) |
Ask and answer user support questions |
-| [Slack](https://s.apache.org/beam-slack-channel) | Chat with users and
developers in the ASF Slack. Note: Please [join the #beam
channel](https://s.apache.org/beam-slack-channel) after you [created an
account](https://s.apache.org/slack-invite). Please do not ask Beam questions
in #general. |
+The official communication channels for Apache projects are their mailing
lists, and Apache
+Beam has two main lists, [email protected] and [email protected]. You
can see
+what are the topics for each of the above.
-</div>
+### Subsribe and Unsubscribe:
-If you have questions about how to use Apache Beam, we recommend you try out
the [user@](https://lists.apache.org/[email protected]) mailing
list, and
[StackOverflow](https://stackoverflow.com/questions/tagged/apache-beam).
+To send emails to these lists you need to subscribe first. To subscribe send a
blank email to [user@]([email protected]) or
[dev@]([email protected]) depending on the list you want to write to.
Review comment:
```suggestion
To send emails to these lists you need to be subscribed. To subscribe send a
blank email to [[email protected]]([email protected])
or [[email protected]]([email protected]) depending on
the list you want to write to.
```
You missed the -subscribe in the dev@ link. I think we should also spell out
the full email address in the link text so people aren't tempted to send a
blank email to [email protected] or [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
