ibzib commented on a change in pull request #13685:
URL: https://github.com/apache/beam/pull/13685#discussion_r561236446
##########
File path: sdks/java/core/build.gradle
##########
@@ -81,14 +83,15 @@ dependencies {
compile library.java.commons_compress
compile library.java.commons_lang3
shadow library.java.jsr305
+ shadow library.java.error_prone_annotations
shadow library.java.jackson_core
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
shadow library.java.avro
shadow library.java.snappy_java
shadow library.java.joda_time
- shadow "org.tukaani:xz:1.8"
+ permitUnusedDeclared "org.tukaani:xz:1.8"
Review comment:
`permitUnusedDeclared` doesn't make sense if `xz` isn't being declared
anymore.
##########
File path: sdks/java/core/build.gradle
##########
@@ -71,6 +72,7 @@ test {
dependencies {
antlr library.java.antlr
+ permitUnusedDeclared "org.antlr:antlr4:4.7"
Review comment:
permitUnusedDeclared is okay here, but we should add a comment
explaining why.
```suggestion
// antlr is used to generate code from sdks/java/core/src/main/antlr/
permitUnusedDeclared library.java.antlr
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
