je-ik commented on a change in pull request #13769:
URL: https://github.com/apache/beam/pull/13769#discussion_r562467943
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/SplitResult.java
##########
@@ -28,7 +28,7 @@
public abstract class SplitResult<RestrictionT> {
/** Returns a {@link SplitResult} for the specified primary and residual
restrictions. */
public static <RestrictionT> SplitResult<RestrictionT> of(
- RestrictionT primary, RestrictionT residual) {
+ @Nullable RestrictionT primary, @Nullable RestrictionT residual) {
Review comment:
Actually no, because the call `SplitRestriction.of(null, ...)` is
reported as bug by tools such as SonarCloud. That is due to implicit `@Nonnull`
added by the checkerframework.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
