boyuanzz commented on a change in pull request #13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r562945561
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -246,9 +247,11 @@ def createRunnerV2ValidatesRunnerTest = { Map args ->
// task directly ('dependsOn buildAndPushDockerContainer'). This ensures the
correct
// task ordering such that the registry doesn't get cleaned up prior to task
completion.
task buildAndPushDockerContainer() {
- dependsOn ":sdks:java:container:docker"
+ def javaVer = project.hasProperty('compileAndRunTestsWithJava11') ? "java11"
: "java8"
+ dependsOn ":sdks:java:container:${javaVer}:docker"
+ finalizedBy 'cleanUpDockerImages'
Review comment:
The `finalizeBy` definition here breaks the Kafka Performance Test[1]
because it makes the docker image get cleaned up as soon as it is pushed.
We define the cleanup logic here:
https://github.com/apache/beam/blame/master/runners/google-cloud-dataflow-java/build.gradle#L280-L287
[1] https://ci-beam.apache.org/job/beam_PerformanceTests_Kafka_IO/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
