ibzib commented on a change in pull request #13791:
URL: https://github.com/apache/beam/pull/13791#discussion_r562963375
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,54 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
Review comment:
Why is this necessary?
##########
File path: sdks/java/io/google-cloud-platform/expansion-service/build.gradle
##########
@@ -31,7 +32,5 @@ description = "Apache Beam :: SDKs :: Java :: IO :: Google
Cloud Platform :: Exp
ext.summary = "Expansion service serving GCP Java IOs"
dependencies {
- compile project(":sdks:java:expansion-service")
Review comment:
I'm pretty sure these dependencies should be `runtimeOnly`.
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -20,7 +20,7 @@ import groovy.json.JsonOutput
plugins { id 'org.apache.beam.module' }
applyJavaNature(
-
+ //enableStrictDependencies:true,
Review comment:
```suggestion
enableStrictDependencies:true,
```
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,54 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
compile library.java.grpc_netty
- compile library.java.grpc_netty_shaded
- compile library.java.grpc_stub
compile library.java.grpc_google_cloud_pubsub_v1
- compile library.java.grpc_google_cloud_pubsublite_v1
compile library.java.guava
- compile library.java.hamcrest_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.junit
compile library.java.netty_handler
- compile library.java.netty_tcnative_boringssl_static
- compile library.java.proto_google_cloud_bigquery_storage_v1beta1
compile library.java.proto_google_cloud_bigtable_v2
compile library.java.proto_google_cloud_datastore_v1
compile library.java.proto_google_cloud_pubsub_v1
compile library.java.proto_google_cloud_pubsublite_v1
- compile library.java.proto_google_cloud_spanner_admin_database_v1
compile library.java.proto_google_common_protos
compile library.java.protobuf_java
compile library.java.slf4j_api
+ compile "com.google.api.grpc:proto-google-cloud-bigquerystorage-v1:0.90.0"
+ compile "com.google.api.grpc:proto-google-cloud-bigtable-admin-v2:1.14.0"
+ compile "com.google.api.grpc:proto-google-cloud-spanner-v1:1.59.0"
+ compile "com.google.api:api-common:1.8.1"
+ compile "com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10"
+ compile "com.google.code.gson:gson:2.8.6"
+ compile "com.google.errorprone:error_prone_annotations:2.3.3"
+ compile "com.google.protobuf:protobuf-java-util:3.11.1"
+ compile "io.grpc:grpc-api:1.27.2"
+ compile "org.apache.beam:beam-vendor-guava-26_0-jre:0.1"
+ compile "org.apache.httpcomponents:httpclient:4.5.12"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
```suggestion
```
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,54 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
compile library.java.grpc_netty
- compile library.java.grpc_netty_shaded
- compile library.java.grpc_stub
compile library.java.grpc_google_cloud_pubsub_v1
- compile library.java.grpc_google_cloud_pubsublite_v1
compile library.java.guava
- compile library.java.hamcrest_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.junit
compile library.java.netty_handler
- compile library.java.netty_tcnative_boringssl_static
- compile library.java.proto_google_cloud_bigquery_storage_v1beta1
compile library.java.proto_google_cloud_bigtable_v2
compile library.java.proto_google_cloud_datastore_v1
compile library.java.proto_google_cloud_pubsub_v1
compile library.java.proto_google_cloud_pubsublite_v1
- compile library.java.proto_google_cloud_spanner_admin_database_v1
compile library.java.proto_google_common_protos
compile library.java.protobuf_java
compile library.java.slf4j_api
+ compile "com.google.api.grpc:proto-google-cloud-bigquerystorage-v1:0.90.0"
Review comment:
Many of these `com.google` dependencies should read from
BeamModulePlugin, which uses the version from
`google_cloud_platform_libraries_bom`.
For example:
https://github.com/apache/beam/blob/809a0b7b69c335236bb2a4ffea5bbda82416d9ab/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L522
Except we need to add
`com.google.api.grpc:proto-google-cloud-bigquerystorage-v1` since it is not
exactly the same as `com.google.api.grpc:proto-google-cloud-bigquerystorage`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
