ihji commented on a change in pull request #13606:
URL: https://github.com/apache/beam/pull/13606#discussion_r562994855
##########
File path: sdks/go/pkg/beam/artifact/materialize.go
##########
@@ -172,7 +236,7 @@ func writeChunks(stream
jobpb.ArtifactRetrievalService_GetArtifactClient, w io.W
return nil
}
-func legacyMaterialize(ctx context.Context, endpoint string, rt string, dest
string) ([]*jobpb.ArtifactMetadata, error) {
+func legacyMaterialize(ctx context.Context, endpoint string, rt string, dest
string) ([]*pipepb.ArtifactInformation, error) {
Review comment:
I think the artifact server for Dataflow still uses legacy protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
