suztomo commented on a change in pull request #13740:
URL: https://github.com/apache/beam/pull/13740#discussion_r563829729



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -436,7 +444,7 @@ class BeamModulePlugin implements Plugin<Project> {
     def google_oauth_clients_version = "1.31.0"
     // Try to keep grpc_version consistent with gRPC version in 
google_cloud_platform_libraries_bom
     def grpc_version = "1.32.2"
-    def guava_version = "25.1-jre"
+    def guava_version = guava25Projects.contains(project.path) ? "25.1-jre" : 
"30.1-jre"

Review comment:
       > In all existing cases where a project requires a library version that 
deviates from library.java, we don't use library.java and instead hard-code 
that dependency in the project's build.gradle.
   
   That's great information. Let me try that. I see hadoop-common does that 
with `force`. Thanks.
   
   Memo for myself in hadoop-common:
   ```
   hadoopVersions.each {kv ->
     configurations."hadoopVersion$kv.key" {
       resolutionStrategy {
         force "org.apache.hadoop:hadoop-client:$kv.value"
         force "org.apache.hadoop:hadoop-common:$kv.value"
         force "org.apache.hadoop:hadoop-mapreduce-client-core:$kv.value"
       }
     }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to