y1chi commented on pull request #13695: URL: https://github.com/apache/beam/pull/13695#issuecomment-767175602
> Changes look good to me. One additional question from me is that do we have a common sense on how much performance overhead it would bring with sampling? I don't have an accurate number but I believe the overhead shouldn't be large since the ExecutionStateSampler uses a separate daemon thread and only updates the timestamps in ExecutionStates every 200ms, I believe this is what the legacy worker has been doing as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
