ibzib commented on a change in pull request #13793:
URL: https://github.com/apache/beam/pull/13793#discussion_r564747798
##########
File path: sdks/java/io/amazon-web-services2/build.gradle
##########
@@ -42,23 +43,25 @@ dependencies {
compile library.java.jackson_core
compile library.java.jackson_annotations
compile library.java.jackson_databind
- compile library.java.jackson_dataformat_cbor
compile library.java.joda_time
compile library.java.slf4j_api
compile "software.amazon.kinesis:amazon-kinesis-client:2.2.5"
compile "commons-lang:commons-lang:2.6"
+ compile "org.apache.commons:commons-lang3:3.9"
+ compile "org.apache.httpcomponents:httpcore:4.4.11"
Review comment:
```suggestion
compile library.java.http_core
```
##########
File path: sdks/java/io/amazon-web-services2/build.gradle
##########
@@ -42,23 +43,25 @@ dependencies {
compile library.java.jackson_core
compile library.java.jackson_annotations
compile library.java.jackson_databind
- compile library.java.jackson_dataformat_cbor
compile library.java.joda_time
compile library.java.slf4j_api
compile "software.amazon.kinesis:amazon-kinesis-client:2.2.5"
compile "commons-lang:commons-lang:2.6"
+ compile "org.apache.commons:commons-lang3:3.9"
Review comment:
```suggestion
compile library.java.commons_lang3
```
##########
File path: sdks/java/io/amazon-web-services/build.gradle
##########
@@ -39,11 +40,12 @@ dependencies {
compile library.java.aws_java_sdk_sns
compile library.java.aws_java_sdk_sqs
compile library.java.aws_java_sdk_sts
- compile "commons-lang:commons-lang:2.6"
compile library.java.jackson_core
compile library.java.jackson_annotations
compile library.java.jackson_databind
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.apache.httpcomponents:httpcore:4.4.11"
Review comment:
library.java.http_core uses version 4.4.12, but I assume 4.4.12 should
be compatible with 4.4.11.
```suggestion
compile library.java.http_core
```
##########
File path: sdks/java/io/amazon-web-services2/build.gradle
##########
@@ -42,23 +43,25 @@ dependencies {
compile library.java.jackson_core
compile library.java.jackson_annotations
compile library.java.jackson_databind
- compile library.java.jackson_dataformat_cbor
compile library.java.joda_time
compile library.java.slf4j_api
compile "software.amazon.kinesis:amazon-kinesis-client:2.2.5"
compile "commons-lang:commons-lang:2.6"
+ compile "org.apache.commons:commons-lang3:3.9"
+ compile "org.apache.httpcomponents:httpcore:4.4.11"
+ compile "software.amazon.awssdk:http-client-spi:2.13.54"
Review comment:
Make `2.13.54` a constant so we can reuse it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
