reuvenlax commented on pull request #13802: URL: https://github.com/apache/beam/pull/13802#issuecomment-768659947
Ah - good point. We still need to exclude those tests for the V2 runner. On Wed, Jan 27, 2021 at 4:03 PM Reuven Lax <[email protected]> wrote: > No - this PR adds support to the legacy runner only. > > On Wed, Jan 27, 2021 at 3:52 PM Boyuan Zhang <[email protected]> > wrote: > >> *@boyuanzz* commented on this pull request. >> ------------------------------ >> >> In runners/google-cloud-dataflow-java/build.gradle >> <https://github.com/apache/beam/pull/13802#discussion_r565721856>: >> >> > @@ -165,8 +163,6 @@ def commonLegacyExcludeCategories = [ >> def commonRunnerV2ExcludeCategories = [ >> 'org.apache.beam.sdk.testing.UsesCommittedMetrics', >> 'org.apache.beam.sdk.testing.UsesGaugeMetrics', >> - 'org.apache.beam.sdk.testing.UsesSetState', >> >> Are MapState and SetState also supported in dataflow runner v2(unified >> worker) within this changes? >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/beam/pull/13802#pullrequestreview-577873503>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AFAYJVNZAEBYVMPTRQAKZGDS4CRKZANCNFSM4WP3BTDA> >> . >> > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
