ibzib commented on a change in pull request #13791:
URL: https://github.com/apache/beam/pull/13791#discussion_r565770696
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -31,17 +31,20 @@ ext.summary = "IO library to read and write Google Cloud
Platform systems from B
dependencies {
compile enforcedPlatform(library.java.google_cloud_platform_libraries_bom)
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(":sdks:java:expansion-service")
+ testCompile project(":sdks:java:expansion-service")
Review comment:
This one is actually needed at compile time, which is why it passes the
strict dependency checker:
https://github.com/apache/beam/blob/0c01636fc8610414859d946cb93eabc904123fc8/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOExternalTest.java#L32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
