scwhittle commented on pull request #13782: URL: https://github.com/apache/beam/pull/13782#issuecomment-769042068
PTAL, I updated to better match ProducerSpEL by using static initializer and static methods instead of a singleton object. I removed the map of deserializer to if it examines headers by instead just delegating to calling either the method with our without headers provided based upon the existence of the method in static initialization. From my understanding this should work because the SDK is compiled with a kafka version supporting the header method, and if during execution the method does not exist it is ok to have the implementation reference it as long as it is not executed. This matches how ConsumerSpEL.getRecordTimestamp works. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
