ibzib commented on a change in pull request #13830:
URL: https://github.com/apache/beam/pull/13830#discussion_r567002012
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -73,7 +73,13 @@ dependencies {
compile "com.alibaba:fastjson:1.2.69"
compile "org.codehaus.janino:janino:3.0.11"
compile "org.codehaus.janino:commons-compiler:3.0.11"
- provided "org.checkerframework:checker-qual:3.4.1"
+ compile library.java.jackson_core
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.mongodb:mongo-java-driver:3.9.1"
Review comment:
This is a different version than the one set in `:sdks:java:io:mongodb`,
which is where this transitive dependency comes from. We should probably make
this a common library in BeamModulePlugin so they can use the same value.
https://github.com/apache/beam/blob/96b4a5813e42733deca57b6198eaf995b5ac3fc2/sdks/java/io/mongodb/build.gradle#L32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
