chamikaramj commented on a change in pull request #13851:
URL: https://github.com/apache/beam/pull/13851#discussion_r567171701
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations_test.py
##########
@@ -227,6 +232,53 @@ def assert_is_topologically_sorted(transform_id,
visited_pcolls):
assert_is_topologically_sorted(
optimized_pipeline_proto.root_transform_ids[0], set())
+ @attr('ValidatesRunner')
+ def test_run_packable_combine_per_key(self):
+ class MultipleCombines(beam.PTransform):
+ def expand(self, pcoll):
+ assert_that(
Review comment:
How do we confirm that combiner packing was triggered here ? This would
pass even without combiner packing, right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
