TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r568798085
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you
can follow to help you get started. This is not the only way to join, but it’s
the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
Review comment:
I think this should be something different, maybe `join_beam_columns 3`?
Right now it's duplicating the committer information.
It would be nice if the key were a string with meaning rather than an integer
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user
and developer mailing lists. Learn how <a
href="https://beam.apache.org/community/contact-us/";>here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join
us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for
the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for
the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in
StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which
has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get
familiar with our <a href="https://beam.apache.org/contribute/";>contribution
guide</a> and <a
href="https://beam.apache.org/contribute/precommit-policies/";>policies</a>. }
+ - { title: Create a Jira account, description: Create a <a
href="https://issues.apache.org/jira/secure/Signup!default.jspa";
target="_blank">Jira account</a> and send an email to [email protected] to
request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code
and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign
an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in
the project and community and help us shape it’s strategy and vision. }
+- list:
+ - { title: Learn about Apache Beam Committers, description: Read how to
become a committer to learn about ways to get nominated for committership. }
- list:
- - Check out the ways you can become a commiter
- - Here is a document that you should read
+ - { title: Learn about the Project Management Committee (PMC),
description: The Project Management Committee (PMC) is the highest recognition
in Apache projects. If you’re interested in becoming part of it, learn more
about it here. }
Review comment:
"read *how to become a committer*" and "learn more about it *here*" in
the PMC section have links to those documents.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user
and developer mailing lists. Learn how <a
href="https://beam.apache.org/community/contact-us/";>here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join
us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for
the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for
the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in
StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which
has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get
familiar with our <a href="https://beam.apache.org/contribute/";>contribution
guide</a> and <a
href="https://beam.apache.org/contribute/precommit-policies/";>policies</a>. }
+ - { title: Create a Jira account, description: Create a <a
href="https://issues.apache.org/jira/secure/Signup!default.jspa";
target="_blank">Jira account</a> and send an email to [email protected] to
request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code
and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign
an Individual Contributor License Agreement (ICLA). Learn more here. }
Review comment:
This is missing everything after "To contribute code", maybe it needs to
be wrapped in quotes?
There also should be a link to some page about ICLAs in "Learn more *here*"
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you
can follow to help you get started. This is not the only way to join, but it’s
the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
-### Still confused?
+## Still have questions?
-We're here for you! Check out ways you can talk to us and we will make sure to
help.
+Send us a note to [email protected] OR mention@ApacheBeam on Twitter OR ask
us in the #beam slack channel. We look forward to seeing you in the community!
Review comment:
I think it would be better to link to the contact us page, or even just
not have this section at all. This page already mentions all of these channels.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user
and developer mailing lists. Learn how <a
href="https://beam.apache.org/community/contact-us/";>here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join
us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for
the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for
the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in
StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which
has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get
familiar with our <a href="https://beam.apache.org/contribute/";>contribution
guide</a> and <a
href="https://beam.apache.org/contribute/precommit-policies/";>policies</a>. }
+ - { title: Create a Jira account, description: Create a <a
href="https://issues.apache.org/jira/secure/Signup!default.jspa";
target="_blank">Jira account</a> and send an email to [email protected] to
request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code
and non-code contributions. Check out this Jira board for some inspiration. }
Review comment:
Please add a link in "this jira board"
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user
and developer mailing lists. Learn how <a
href="https://beam.apache.org/community/contact-us/";>here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join
us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for
the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for
the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in
StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which
has the latest events organized by the community. }
Review comment:
Please add links for
- [ ] the-asf Slack
- [ ] @ApacheBeam Twitter
- [ ] Apache Beam YouTube
- [ ] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user
and developer mailing lists. Learn how <a
href="https://beam.apache.org/community/contact-us/";>here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join
us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for
the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for
the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in
StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which
has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get
familiar with our <a href="https://beam.apache.org/contribute/";>contribution
guide</a> and <a
href="https://beam.apache.org/contribute/precommit-policies/";>policies</a>. }
+ - { title: Create a Jira account, description: Create a <a
href="https://issues.apache.org/jira/secure/Signup!default.jspa";
target="_blank">Jira account</a> and send an email to [email protected] to
request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code
and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign
an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in
the project and community and help us shape it’s strategy and vision. }
Review comment:
nit: please remove the extra whitespace after "Stay engaged"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
