boyuanzz commented on a change in pull request #13750:
URL: https://github.com/apache/beam/pull/13750#discussion_r568874739
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -158,6 +159,28 @@
* Read#withValueDeserializerAndCoder(Class, Coder)}. Note that Kafka messages
are interpreted using
* key and value <i>deserializers</i>.
*
+ * <h3>Read From Kafka Dynamically</h3>
+ *
+ * For a given kafka bootstrap_server, KafkaIO is also able to detect and read
from available {@link
+ * TopicPartition} dynamically. For more design details, please refer to
+ *
https://docs.google.com/document/d/1FU3GxVRetHPLVizP3Mdv6mP5tpjZ3fd99qNjUI5DT5k/.
To enable
Review comment:
Will do. Thanks for pointing this out.
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -553,6 +587,9 @@
abstract Builder<K, V> setValueDeserializerProvider(
DeserializerProvider deserializerProvider);
+ abstract Builder<K, V> setCheckStopReadingFn(
Review comment:
Yeah, I opened this PR prior to mergeing #13710. I'll rebase them.
Thanks for catching it : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
