KevinGG commented on a change in pull request #13881:
URL: https://github.com/apache/beam/pull/13881#discussion_r569635200
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment_test.py
##########
@@ -180,91 +180,81 @@ def
test_cleanup_invoked_when_new_env_replace_not_none_env(
self, mocked_cleanup):
ie._interactive_beam_env = None
ie.new_env()
- mocked_cleanup.assert_not_called()
ie.new_env()
- mocked_cleanup.assert_called_once()
+ mocked_cleanup.assert_called()
Review comment:
Yes, a little bit. We don't really care about if cleanup is called when
_interactive_beam_env is None, because it's a NOOP either way. In this
scenario, we are testing when ie.new_env() is called more than once (so that a
new env did replace an old env), cleanup is called at least once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
