ibzib commented on a change in pull request #13891:
URL: https://github.com/apache/beam/pull/13891#discussion_r569874724
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -127,6 +144,53 @@ static boolean isEndOfInput(ParseResumeLocation
parseResumeLocation) {
return tables.build();
}
+ /** Returns the fully qualified name of the function defined in the
statement. */
+ static String getFunctionQualifiedName(ResolvedCreateFunctionStmt
createFunctionStmt) {
+ return String.format(
+ "%s:%s",
+ getFunctionGroup(createFunctionStmt), String.join(".",
createFunctionStmt.getNamePath()));
+ }
+
+ static String getFunctionGroup(ResolvedCreateFunctionStmt
createFunctionStmt) {
+ switch (createFunctionStmt.getLanguage().toUpperCase()) {
+ case "JAVA":
+ if (createFunctionStmt.getIsAggregate()) {
+ throw new UnsupportedOperationException(
+ "Java SQL aggregate functions are not supported (BEAM-10925).");
+ }
+ return USER_DEFINED_JAVA_SCALAR_FUNCTIONS;
+ case "SQL":
+ if (createFunctionStmt.getIsAggregate()) {
+ throw new UnsupportedOperationException(
+ "Native SQL aggregate functions are not supported (BEAM-9954).");
+ }
+ return USER_DEFINED_FUNCTIONS;
+ case "PY":
Review comment:
BigQuery supports `JS`. The rest of them I made up.
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -127,6 +144,53 @@ static boolean isEndOfInput(ParseResumeLocation
parseResumeLocation) {
return tables.build();
}
+ /** Returns the fully qualified name of the function defined in the
statement. */
+ static String getFunctionQualifiedName(ResolvedCreateFunctionStmt
createFunctionStmt) {
+ return String.format(
+ "%s:%s",
+ getFunctionGroup(createFunctionStmt), String.join(".",
createFunctionStmt.getNamePath()));
+ }
+
+ static String getFunctionGroup(ResolvedCreateFunctionStmt
createFunctionStmt) {
+ switch (createFunctionStmt.getLanguage().toUpperCase()) {
+ case "JAVA":
+ if (createFunctionStmt.getIsAggregate()) {
+ throw new UnsupportedOperationException(
+ "Java SQL aggregate functions are not supported (BEAM-10925).");
+ }
+ return USER_DEFINED_JAVA_SCALAR_FUNCTIONS;
+ case "SQL":
+ if (createFunctionStmt.getIsAggregate()) {
+ throw new UnsupportedOperationException(
+ "Native SQL aggregate functions are not supported (BEAM-9954).");
+ }
+ return USER_DEFINED_FUNCTIONS;
+ case "PY":
Review comment:
BigQuery supports `JS`. I made up the rest of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
