iindyk commented on a change in pull request #13175:
URL: https://github.com/apache/beam/pull/13175#discussion_r570716679
##########
File path: sdks/python/apache_beam/transforms/stats_test.py
##########
@@ -482,13 +482,74 @@ def test_alternate_quantiles(self):
equal_to([["ccccc", "aaa", "b"]]),
label='checkWithKeyAndReversed')
+ def test_batched_quantiles(self):
Review comment:
1. I think the tests use DirectRunner, so probably no.
2. The approximation will be properly tested only if either the number of
inputs will be large with default settings, or max_num_elements and epsilon
will be set to extremely low and large values, respectively. I tested
approximation with large number of inputs and FlumeCppRunner during
development, but it took some time to complete, so it's probably not suitable
for continuous testing. It might make sense for me to initialize the CombineFn
with the extreme values and test add_input, merge_accumulators and
extract_output directly, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
