kennknowles commented on a change in pull request #13861:
URL: https://github.com/apache/beam/pull/13861#discussion_r571312280
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateSampler.java
##########
@@ -36,8 +36,7 @@
/** Monitors the execution of one or more execution threads. */
public class ExecutionStateSampler {
- private final ConcurrentSkipListSet<ExecutionStateTracker> activeTrackers =
- new ConcurrentSkipListSet<>();
+ private final HashSet<ExecutionStateTracker> activeTrackers = new
HashSet<>();
Review comment:
`@GuardedBy(this)`? Or a comment to that effect. Minor benefit of the
annotation over a comment is that there are analyses (including
checkerframework that we already use) that can check them statically or
dynamically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
