boyuanzz commented on a change in pull request #13893:
URL: https://github.com/apache/beam/pull/13893#discussion_r572283447
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -705,6 +718,17 @@ void reset() throws Exception {
resetFunction.run();
}
}
+
+ void shutdown() {
+ for (ThrowingRunnable tearDownFunction : getTearDownFunctions()) {
+ LOG.debug("Tearing down function {}", tearDownFunction);
+ try {
+ tearDownFunction.run();
+ } catch (Exception e) {
+ LOG.error("Failed to call teardown function: {}", e);
Review comment:
It seems like dofn lifecycle section is about still non-portable
execution. We should add(or update it to) portable execution. I'll add some
javadoc to DoFn first and we can update dofn lifecycle together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
