tvalentyn commented on a change in pull request #13175:
URL: https://github.com/apache/beam/pull/13175#discussion_r573220608
##########
File path: sdks/python/apache_beam/transforms/stats.py
##########
@@ -582,6 +861,8 @@ def create(
weighted: (optional) if set to True, the combiner produces weighted
quantiles. The input elements are then expected to be tuples of values
with the corresponding weight.
+ batch_input: (optional) if set to True, inputs are expected to be batches
+ of elements.
Review comment:
Agree that this is out of scope, SGTM to add a note in case someone
happens to read through this..
AFAICT this is not critical, and these numbers numbers are tied to
MAX_ELEMENTS, which is somewhat arbitrary and not exposed to in the user.
Perhaps if we decide to expose MAX_ELEMENTS as a transform param, we'd have to
take a closer look at this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
