yifanmai commented on pull request #13877: URL: https://github.com/apache/beam/pull/13877#issuecomment-776288678
> Maybe we could simplify things by only supporting portable job submission? Even with portable job submission, the subtransform structure is different (CombineValues is a primitive rather than a composite). [CombineValuesPTransformOverride](https://github.com/apache/beam/blob/595c25263638b3d5624875e46b69a442cedb09a7/sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py#L128) performs this substitution in DataflowRunner [before](https://github.com/apache/beam/blob/595c25263638b3d5624875e46b69a442cedb09a7/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L479) the pipeline is converted to a proto. So the optimizer will still see the Dataflow-specific subtransform structure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
