aaltay commented on pull request #13933: URL: https://github.com/apache/beam/pull/13933#issuecomment-776870869
> > > > I think if they are solely dependencies for google-cloud-build they won't be needed anymore? Do we need some special handling? > > > > > > > > > Thanks. I thought originally that this PR checks in the google-cloud-build code. Looks like you generated client code with apitools. google-apitools is deprecated, and we were actually trying to move away from depending on google-apitools and use official google-cloud-python libraries. This may be a step in the opposite direction. cc: @aaltay - do you have any opinion here? Perhaps we should look into addressing the difficulty of managing the third_party deps for internal testing instead. > > > > > > > do you have any opinion here? > > > > > > This is just an **opinion**: It would be better to avoid generated clients. They do end up causing more issues than regular dependencies, they are hard to upgrade, usually stale, and apitools has been deprecated for a long time. I am fine if we want to do this in there interim and unblock some testing, but a much better solution would be to make this a proper dependency. I do not know the specific issues but this is only one of many dependencies and I assume we will have ways to address the issues with using a dependency. > > I think it should be easy to switch back to use the third_party library any time(assuming cloud build team will manage the library internally). The difficulties of using the third party google-cloud-build library are: > > * Right now there are dozens of dependencies of google-cloud-build library that are un-managed. > * or managed by some other teams but with many customized import hacks. > * some dependencies could have been imported to a certain version to be used by certain targets, the version does not satisfy google-cloud-build requirements. > > The third party dependency issue is a lot more chaos and hard to control than using google-apitools to generate the client at the moment. Sounds reasonable to me to proceed with this PR and at the same time ask cloud build team to improve the internal library story. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
