KevinGG commented on pull request #13984:
URL: https://github.com/apache/beam/pull/13984#issuecomment-778422690


   The code that introduces a cleanup probably comes from:
   
![33GFESeeJiX8hkZ](https://user-images.githubusercontent.com/4423149/107815922-e69b7800-6d28-11eb-915c-5435b5535f38.png)
   
   The test creates a bunch of pipeline objects with references to them in the 
interactive environment. The test tries to find out whether a 
`cleanup(pipeline)` is invoked when explicitly tracking all user pipelines if 
some of the pipelines held in the environment is no longer in scope. Of all the 
pipeline objects created, only one would be cleaned up (because we 
intentionally put a string typed "pipeline" in the interactive environment so 
it would just "disappear" when tracking pipeline-typed objects), so cleanup 
should just be invoked once during the call.
   
   R: @TheNeuralBit 
   
   PTAL, thx!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to