TheNeuralBit commented on a change in pull request #13944:
URL: https://github.com/apache/beam/pull/13944#discussion_r578776686
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
##########
@@ -737,11 +738,15 @@ def __init__(self,
def host_from_worker(self):
# type: () -> str
- if sys.platform == "darwin":
+ if sys.platform == 'darwin':
# See https://docs.docker.com/docker-for-mac/networking/
return 'host.docker.internal'
- else:
- return super(DockerSdkWorkerHandler, self).host_from_worker()
+ if sys.platform != 'win32' and is_in_notebook():
Review comment:
If it works whether we're in a container or not, should we just do this
all the time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
