TheNeuralBit commented on a change in pull request #13932:
URL: https://github.com/apache/beam/pull/13932#discussion_r578855092
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -95,7 +138,13 @@ def fillna(self, value, method, axis, **kwargs):
def ffill(self, **kwargs):
return self.fillna(method='ffill', **kwargs)
+ @frame_base.args_to_kwargs(pd.DataFrame)
+ @frame_base.populate_defaults(pd.DataFrame)
+ def bfill(self, **kwargs):
+ return self.fillna(method='bfill', **kwargs)
Review comment:
Yep! fillna will throw for this:
https://github.com/apache/beam/blob/b787dd1e252cbb9f8684ad0e1428bf7a2419e164/sdks/python/apache_beam/dataframe/frames.py#L76-L78
I followed your example from ffill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
