boyuanzz commented on pull request #14013: URL: https://github.com/apache/beam/pull/14013#issuecomment-783598412
> > I'm afraid that setting watermark both before and after the tryClaim loop is still not enough. For most cases, every time tryClaim is called and there is one output record, the watermark should advance. If we only set watermark outside of tryClaim loop, we will still hold back the watermark somehow. > > Alright, that is true. I'd suggest we add watermark into the `UnboundedSourceValue`, I'd prefer to avoid materializing the `currentRestriction()` in the tryClaim loop. WDYT? That sounds good to me. Would you like to make the change in this PR together? Meanwhile I'll double check the implementation to ensure we don't introduce additional bugs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
