masahitojp commented on pull request #13994: URL: https://github.com/apache/beam/pull/13994#issuecomment-784200417
The current master branch depends on 16.3.0 (#13990) In other words, there was no longer any affect on us. > Note that there's back-and-forth (#13765 and #13972) of GCP dependencies in the last couple of weeks. #13990 is merged, and this PR is restarted, especially since it does not seem to be causing any problems in testing. ---- Now I've changed the purpose of this PR. ## what > bump google-cloud-pubsub to 1.110.3, because we follwed dependencies in google_cloud_platform_libraries_bom sets version. The current master branch depends on 16.3.0 (#13990) https://storage.googleapis.com/cloud-opensource-java-dashboard/com.google.cloud/libraries-bom/16.3.0/artifact_details.html ^ It depends on com.google.cloud:google-cloud-pubsub:1.110.3 Since this is newer than the current master(1.108.6 ) , I think it's better to update ## why(background) The apache beam specifies the versions of the following packages * com.google.cloud:google-cloud-pubsub But this package has dependencies with the following packages but this one is specified by `google_cloud_platform_libraries_bom ` * com.google.api.grpc:proto-google-cloud-pubsub-v1 * com.google.api.grpc:grpc-google-cloud-pubsub-v1 The dependencies of this package are difficult to understand for people who don't know about it, so there is a possibility that the dependencies will be broken unintentionally in the future. For this reason, I thought it would be better for me to unify them into `google_cloud_platform_libraries_bom ` ^ It depends on com.google.cloud:google-cloud-pubsub:1.110.3 Since this is newer than the current master(1.108.6 ) , I think it's better to update ## results of sh sdks/java/build-tools/beam-linkage-check.sh origin/master beam-11770 Success https://gist.github.com/masahitojp/6a292e3d8ff5506383fca3a44805bafb (Thanks to your support @suztomo ) ---- Could you re-review this PR? R: @TheNeuralBit @iemejia ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
