nehsyc commented on a change in pull request #14033:
URL: https://github.com/apache/beam/pull/14033#discussion_r581311537



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1759,6 +1814,8 @@ def serialize(side_inputs):
         'triggering_frequency': self.triggering_frequency,
         'validate': self._validate,
         'temp_file_format': self._temp_file_format,
+        'ignore_insert_ids': self._ignore_insert_ids,

Review comment:
       `ignore_insert_ids` was previously not added to runner api parameter. 
Wondering if this is a bug as when we convert from the runner api the parameter 
will be lost.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to