chamikaramj commented on a change in pull request #14001:
URL: https://github.com/apache/beam/pull/14001#discussion_r581321380
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslation.java
##########
@@ -295,10 +299,17 @@ public static FunctionSpec toProto(WindowFn<?, ?>
windowFn, SdkComponents compon
.setAllowedLateness(windowingStrategy.getAllowedLateness().getMillis())
.setTrigger(TriggerTranslation.toProto(windowingStrategy.getTrigger()))
.setWindowFn(windowFnSpec)
-
.setAssignsToOneWindow(windowingStrategy.getWindowFn().assignsToOneWindow())
+ .setAssignsToOneWindow(windowFn.assignsToOneWindow())
+ .setMergeStatus(
+ windowFn instanceof InvalidWindows
+ ? (((InvalidWindows)
windowFn).getOriginalWindowFn().isNonMerging()
Review comment:
Are we assuming that usage here (not just the InvalidWindows spec) ? If
so probably this at least needs a comment about that assumption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
