aaltay commented on pull request #14045: URL: https://github.com/apache/beam/pull/14045#issuecomment-784675510
I glanced at this. It looks good. Some high level comments: - I am not sure the info boxes related to disk speeds are relevant. Read/Write might be mostly happening to a service and very unlikely to use in memory sources. - The parts that refer to creating a sink transform and creating a source transform might cause confusion. Especially the source one, since source has a specific meaning. I would like to load balance these reviews across the team. For this one I will nominate @emilymye in addition to @rosetn. Feel free to ping me once this is ready to merge after both reviews. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
