ibzib commented on a change in pull request #14050:
URL: https://github.com/apache/beam/pull/14050#discussion_r581569030
##########
File path: sdks/java/io/elasticsearch/build.gradle
##########
@@ -17,16 +17,24 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(automaticModuleName: 'org.apache.beam.sdk.io.elasticsearch')
+applyJavaNature(enableStrictDependencies:true,automaticModuleName:
'org.apache.beam.sdk.io.elasticsearch')
description = "Apache Beam :: SDKs :: Java :: IO :: Elasticsearch"
ext.summary = "IO to read and write on Elasticsearch"
dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile library.java.jackson_databind
compile library.java.jackson_annotations
+ permitUnusedDeclared library.java.jackson_annotations
+ compile library.java.jackson_core
+ compile library.java.jackson_databind
+ compile library.java.joda_time
+ compile "org.apache.httpcomponents:httpasyncclient:4.1.4"
+ compile "org.apache.httpcomponents:httpclient:4.5.10"
+ compile "org.apache.httpcomponents:httpcore-nio:4.4.12"
+ compile "org.apache.httpcomponents:httpcore:4.4.12"
Review comment:
Use common libraries for httpcore and httpclient.
##########
File path: sdks/java/io/elasticsearch/build.gradle
##########
@@ -17,16 +17,24 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(automaticModuleName: 'org.apache.beam.sdk.io.elasticsearch')
+applyJavaNature(enableStrictDependencies:true,automaticModuleName:
'org.apache.beam.sdk.io.elasticsearch')
description = "Apache Beam :: SDKs :: Java :: IO :: Elasticsearch"
ext.summary = "IO to read and write on Elasticsearch"
dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile library.java.jackson_databind
compile library.java.jackson_annotations
+ permitUnusedDeclared library.java.jackson_annotations
Review comment:
Link to the JIRA
##########
File path: sdks/java/io/elasticsearch/build.gradle
##########
@@ -17,16 +17,24 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(automaticModuleName: 'org.apache.beam.sdk.io.elasticsearch')
+applyJavaNature(enableStrictDependencies:true,automaticModuleName:
'org.apache.beam.sdk.io.elasticsearch')
Review comment:
nit: spacing
```suggestion
applyJavaNature(enableStrictDependencies: true, automaticModuleName:
'org.apache.beam.sdk.io.elasticsearch')
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
