ibzib commented on a change in pull request #14057:
URL: https://github.com/apache/beam/pull/14057#discussion_r581572190
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -49,6 +50,9 @@ dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
compile project(":sdks:java:expansion-service")
+ permitUnusedDeclared project(":sdks:java:expansion-service")
Review comment:
link to the JIRA
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -49,6 +50,9 @@ dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
compile project(":sdks:java:expansion-service")
+ permitUnusedDeclared project(":sdks:java:expansion-service")
+ compile "org.apache.kafka:kafka-clients:2.4.1"
Review comment:
kafka-clients should not be a compile dependency. And I don't see an
error for it:
```
Execution failed for task ':sdks:java:io:kafka:analyzeClassesDependencies'.
> Dependency analysis found issues.
usedUndeclaredArtifacts:
- io.confluent:kafka-schema-registry-client:5.3.2@jar
- org.apache.avro:avro:1.8.2@jar
unusedDeclaredArtifacts:
- beam.sdks.java:expansion-service:2.29.0-SNAPSHOT@jar
```
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -20,6 +20,7 @@ import java.util.stream.Collectors
plugins { id 'org.apache.beam.module' }
applyJavaNature(
+ enableStrictDependencies:true,
Review comment:
nit: spacing
```suggestion
enableStrictDependencies: true,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
