tvalentyn edited a comment on pull request #13887: URL: https://github.com/apache/beam/pull/13887#issuecomment-785285326
I think we need to verify that Beam's cythonization is using Py3 semantic before merging this or similar changes, otherwise the behavior in cythonized codepath could change. For example there are directives in some files: https://github.com/apache/beam/blob/53560566c1482cd54a03641fe82089a7ead6bf79/sdks/python/apache_beam/coders/coder_impl.py#L18 but we may not have them in other files. I don't know if there is a way to make it a default when we invoke Cython or build wheels for all files without upgrading to Cython 3 when this becomes default. CC: @robertwb who may have advice. I'll have to park this change for a bit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
