udim commented on a change in pull request #13839:
URL: https://github.com/apache/beam/pull/13839#discussion_r582438166



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_file_loads.py
##########
@@ -858,9 +859,13 @@ def _load_data(
             lambda x,
             deleting_tables: deleting_tables,
             pvalue.AsIter(temp_tables_pc))
-        | "RemoveTempTables/AddUselessValue" >> beam.Map(lambda x: (x, None))
+        # TableReference has no deterministic coder, but as this de-duplication

Review comment:
       Ack. The official BigQuery client (which this code doesn't use) has a 
hashable wrapper for this.
   
https://googleapis.dev/python/bigquery/latest/generated/google.cloud.bigquery.table.TableReference.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to