boyuanzz commented on a change in pull request #14072:
URL: https://github.com/apache/beam/pull/14072#discussion_r582539861



##########
File path: 
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -978,12 +988,8 @@ public DataflowPipelineJob run(Pipeline pipeline) {
     dataflowOptions.setPipelineUrl(stagedPipeline.getLocation());
 
     if (!isNullOrEmpty(dataflowOptions.getDataflowWorkerJar())) {

Review comment:
       I think we should only stage dataflow worker jar when `! 
useUnifiedWorker ()`. I can have a cleanup PR for that after this one is in.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to