dpcollins-google commented on pull request #14077:
URL: https://github.com/apache/beam/pull/14077#issuecomment-786079964


   > Thanks for putting all of these together. I think these are all blocked by 
[BEAM-9378](https://issues.apache.org/jira/browse/BEAM-9378) and the calcite 
upgrade (CC: @amaliujia). I think this is worth merging, if we just add 
`@Ignore(BEAM-9378)` on the failing test cases.
   > 
   > If we do go ahead with that I'd just ask that you separate out the 
refactor into a separate commit for ease of review.
   
   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to