ibzib commented on a change in pull request #13791:
URL: https://github.com/apache/beam/pull/13791#discussion_r583157452
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -72,26 +80,19 @@ dependencies {
compile library.java.proto_google_cloud_pubsublite_v1
compile library.java.proto_google_common_protos
compile library.java.protobuf_java
+ compile library.java.protobuf_java_util
compile library.java.slf4j_api
+ compile library.java.vendored_grpc_1_26_0
+ compile library.java.vendored_guava_26_0_jre
+
compile "com.google.api.grpc:proto-google-cloud-bigquerystorage-v1:0.90.0"
compile "com.google.api.grpc:proto-google-cloud-bigtable-admin-v2:1.14.0"
compile "com.google.api.grpc:proto-google-cloud-spanner-v1:1.59.0"
- compile "com.google.api:api-common:1.8.1"
- compile "com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10"
- compile "com.google.code.gson:gson:2.8.6"
- compile "com.google.errorprone:error_prone_annotations:2.3.3"
- compile "com.google.protobuf:protobuf-java-util:3.11.1"
- compile "io.grpc:grpc-api:1.27.2"
- compile "org.apache.beam:beam-vendor-guava-26_0-jre:0.1"
- compile "org.apache.httpcomponents:httpclient:4.5.12"
- compile "org.apache.httpcomponents:httpcore:4.4.13"
- compile "org.checkerframework:checker-qual:2.0.0"
- compile library.java.jackson_core
- compile "org.hamcrest:hamcrest:2.1"
compile "org.threeten:threetenbp:1.4.4"
- compile "org.apache.beam:beam-vendor-grpc-1_26_0:0.3"
+
Review comment:
Nit: there are already hardcoded declarations at the top of the
`dependencies` block.
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -53,48 +58,78 @@ dependencies {
compile(library.java.google_cloud_core_grpc) {
exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
}
+ permitUnusedDeclared library.java.google_cloud_core_grpc // BEAM-11761
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
+ compile library.java.google_code_gson
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.grpc_alts
+ permitUnusedDeclared library.java.grpc_alts // BEAM-11761
compile library.java.grpc_api
compile library.java.grpc_auth
compile library.java.grpc_core
+ permitUnusedDeclared library.java.grpc_core // BEAM-11761
compile library.java.grpc_context
+ permitUnusedDeclared library.java.grpc_context // BEAM-11761
compile library.java.grpc_grpclb
+ permitUnusedDeclared library.java.grpc_grpclb // BEAM-11761
compile library.java.grpc_netty
compile library.java.grpc_netty_shaded
+ permitUnusedDeclared library.java.grpc_netty_shaded // BEAM-11761
compile library.java.grpc_stub
+ permitUnusedDeclared library.java.grpc_stub // BEAM-11761
compile library.java.grpc_google_cloud_pubsub_v1
compile library.java.grpc_google_cloud_pubsublite_v1
+ permitUnusedDeclared library.java.grpc_google_cloud_pubsublite_v1 //
BEAM-11761
compile library.java.guava
+ compile library.java.hamcrest
+ compile library.java.http_client
compile library.java.hamcrest_core
+ permitUnusedDeclared library.java.hamcrest_core // BEAM-11761
+ compile library.java.http_core
+ compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.junit
compile library.java.netty_handler
compile library.java.netty_tcnative_boringssl_static
+ permitUnusedDeclared library.java.netty_tcnative_boringssl_static //
BEAM-11761
+ compile library.java.proto_google_cloud_bigquery_storage_v1
+ compile library.java.proto_google_cloud_bigquery_storage_v1beta1
Review comment:
`proto_google_cloud_bigquery_storage_v1beta1` is introduced and marked
as permitUnusedDeclared in this PR. It looks like it was removed recently, so
please remove it:
https://github.com/apache/beam/pull/13765/files#diff-098a130c2e6da0538aa36c54133e8cd0b44d171886934e3dd94e48d77a84a6d1R81.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
