ibzib commented on a change in pull request #14015:
URL: https://github.com/apache/beam/pull/14015#discussion_r582248488
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -141,11 +143,14 @@ public QueryPlanner createPlanner(
* group is equal to {@code SqlAnalyzer.USER_DEFINED_JAVA_SCALAR_FUNCTIONS}
*/
static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x) {
+ HashSet<Integer> udfs = new HashSet<>();
Review comment:
This should be scoped inside `for (RelNode relNode : resList)`.
Does anyone know if it's even possible for `x` to contain multiple rels?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
